linux-kernel - Re: [PATCH] iio: light: gp2ap020a00f: Remove some unused field in struct gp2ap020a00f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240504124407.1ac6f07e@jic23-huawei>
Date: Sat, 4 May 2024 12:44:07 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Lars-Peter Clausen <lars@...afoo.de>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: light: gp2ap020a00f: Remove some unused field in
 struct gp2ap020a00f_data

On Wed,  1 May 2024 14:55:17 +0200
Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> In "struct gp2ap020a00f_data", the 'pdata' field is unused.
> 
> Moreover the "struct gp2ap020a00f_platform_data" is defined nowhere.
> Neither in this file, nor in a global .h file, so it is completely
> pointless.
> 
> So, remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Applied to the togreg branch of iio.git and pushed out as testing to let
the bots play with it.

Note I'll be rebasing that tree on rc1 once available.

Thanks,

Jonathan

> ---
> Compile tested only.
> 
> It was added in the initial commit bf29fbeaa13d ("iio: gp2ap020a00f: Add a
> driver for the device") but was never used.
> ---
>  drivers/iio/light/gp2ap020a00f.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c
> index 9f41724819b6..9a476697aa1f 100644
> --- a/drivers/iio/light/gp2ap020a00f.c
> +++ b/drivers/iio/light/gp2ap020a00f.c
> @@ -237,7 +237,6 @@ enum gp2ap020a00f_thresh_val_id {
>  };
>  
>  struct gp2ap020a00f_data {
> -	const struct gp2ap020a00f_platform_data *pdata;
>  	struct i2c_client *client;
>  	struct mutex lock;
>  	char *buffer;