linux-kernel - Re: [PATCH 2/2] dt-bindings: iio: imu: bmi160: add bmi120

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240504125228.0efe24bf@jic23-huawei>
Date: Sat, 4 May 2024 12:52:42 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Barnabás Czémán <trabarni@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, Danila Tikhonov
 <danila@...xyga.com>
Subject: Re: [PATCH 2/2] dt-bindings: iio: imu: bmi160: add bmi120

On Sat, 04 May 2024 01:45:25 +0200
Barnabás Czémán <trabarni@...il.com> wrote:

> From: Danila Tikhonov <danila@...xyga.com>
> 
> Document bosch,bmi120 compatible.
> 
> Signed-off-by: Danila Tikhonov <danila@...xyga.com>
> Signed-off-by: Barnbás Czémán <trabarni@...il.com>
> ---
>  Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml
> index 47cfba939ca6..9ca874aea837 100644
> --- a/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml
> @@ -16,7 +16,9 @@ description: |
>  
>  properties:
>    compatible:
> -    const: bosch,bmi160
> +    enum:
> +      - bosch,bmi120
> +      - bosch,bmi160

Please use a fallback compatible for the bmi120 similar to handling
done for st,asm330lhhx in st,lsm6dsx.yaml

Whilst the driver would currently reject the chip ID, the binding should
assume the driver does fallback handling correctly.

Jonathan

>  
>    reg:
>      maxItems: 1
>