linux-kernel - Re: [PATCH 07/18] clk: imx: pll14xx: potential integer overflow eliminated by casting to u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240504115828.GA3666@francesco-nb>
Date: Sat, 4 May 2024 13:58:28 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: Abel Vesa <abelvesa@...nel.org>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, Jacky Bai <ping.bai@....com>,
	Ye Li <ye.li@....com>, Dong Aisheng <aisheng.dong@....com>,
	linux-clk@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Abel Vesa <abel.vesa@...aro.org>, Peng Fan <peng.fan@....com>,
	Florin Pavelescu <florin.pavelescu@....com>,
	Viorel Suman <viorel.suman@....com>
Subject: Re: [PATCH 07/18] clk: imx: pll14xx: potential integer overflow
 eliminated by casting to u64

Hello Peng,

On Sat, May 04, 2024 at 08:49:00AM +0800, Peng Fan (OSS) wrote:
> From: Florin Pavelescu <florin.pavelescu@....com>
> 
> Cast to u64, so that multiplications and additions will be done
> in 64-bit arithmetic (and the results will also be 64-bit)
> and the possibility of integer overflow is eliminated.
> 
> Fix Unintentional integer overflow reported by Coverity

Fixes tag if this is a fix?

It would be interesting in general if this can be trigger in real life
and with which side effects or if we are just silencing the tool