linux-kernel - Re: [PATCH] dmaengine: idxd: Avoid unnecessary destruction of file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171482683528.61200.11644725480487646401.b4-ty@kernel.org>
Date: Sat, 04 May 2024 18:17:15 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Dave Jiang <dave.jiang@...el.com>, Fenghua Yu <fenghua.yu@...el.com>
Cc: dmaengine@...r.kernel.org, linux-kernel <linux-kernel@...r.kernel.org>, 
 Lijun Pan <lijun.pan@...el.com>
Subject: Re: [PATCH] dmaengine: idxd: Avoid unnecessary destruction of
 file_ida


On Mon, 29 Jan 2024 17:39:54 -0800, Fenghua Yu wrote:
> file_ida is allocated during cdev open and is freed accordingly
> during cdev release. This sequence is guaranteed by driver file
> operations. Therefore, there is no need to destroy an already empty
> file_ida when the WQ cdev is removed.
> 
> Worse, ida_free() in cdev release may happen after destruction of
> file_ida per WQ cdev. This can lead to accessing an id in file_ida
> after it has been destroyed, resulting in a kernel panic.
> 
> [...]

Applied, thanks!

[1/1] dmaengine: idxd: Avoid unnecessary destruction of file_ida
      commit: 76e43fa6a456787bad31b8d0daeabda27351a480

Best regards,
-- 
~Vinod