[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com>
Date: Sat, 04 May 2024 21:19:58 +0800
From: "Peng Fan (OSS)" <peng.fan@....nxp.com>
To: Linus Walleij <linus.walleij@...aro.org>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>, Dvorkin Dmitry <dvorkin@...bo.com>,
Wells Lu <wellslutw@...il.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Emil Renner Berthing <kernel@...il.dk>,
Jianlong Huang <jianlong.huang@...rfivetech.com>,
Hal Feng <hal.feng@...rfivetech.com>, Orson Zhai <orsonzhai@...il.com>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
Chunyan Zhang <zhang.lyra@...il.com>, Viresh Kumar <vireshk@...nel.org>,
Shiraz Hashim <shiraz.linux.kernel@...il.com>, soc@...nel.org,
Krzysztof Kozlowski <krzk@...nel.org>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Alim Akhtar <alim.akhtar@...sung.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Patrice Chotard <patrice.chotard@...s.st.com>,
Heiko Stuebner <heiko@...ech.de>, Damien Le Moal <dlemoal@...nel.org>,
Ludovic Desroches <ludovic.desroches@...rochip.com>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Claudiu Beznea <claudiu.beznea@...on.dev>,
Dong Aisheng <aisheng.dong@....com>, Fabio Estevam <festevam@...il.com>,
Shawn Guo <shawnguo@...nel.org>, Jacky Bai <ping.bai@....com>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Chester Lin <chester62515@...il.com>, Matthias Brugger <mbrugger@...e.com>,
Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>,
Sean Wang <sean.wang@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Andrew Jeffery <andrew@...econstruct.com.au>, Joel Stanley <joel@....id.au>,
Dan Carpenter <dan.carpenter@...aro.org>, Tony Lindgren <tony@...mide.com>,
Stephen Warren <swarren@...dotorg.org>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-stm32@...md-mailman.stormreply.com, linux-samsung-soc@...r.kernel.org,
linux-renesas-soc@...r.kernel.org, linux-rockchip@...ts.infradead.org,
linux-riscv@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
imx@...ts.linux.dev, linux-aspeed@...ts.ozlabs.org,
openbmc@...ts.ozlabs.org, Peng Fan <peng.fan@....com>,
Emil Renner Berthing <emil.renner.berthing@...onical.com>
Subject: [PATCH v2 00/20] pinctrl: Use scope based of_node_put() cleanups
Use scope based of_node_put() to simplify code. It reduces the chance
of forgetting of_node_put(), and also simplifies error handling path.
I not able to test the changes on all the hardwares, so driver owners,
please help review when you have time.
This patchset was inspired from Dan's comments on pinctrl-scmi-imx.c,
thanks.
Signed-off-by: Peng Fan <peng.fan@....com>
---
Changes in v2:
- Drop aspeed changes per Andrew Jeffery
- Drop changes to code pattern that of_node_get(or other refcount
increasing) followed by of_node_put. That said, but I still have a
change for samsung pinctrl that drops several of_node_put places. If
this is not welcomed, patch 20/20 could be dropped.
- Add Fix tag for patch 1
- Add A-b for patch 4
- Drop unneeded {} in patch 8 Per Dan Carpenter
- Add a new patch 18.
- Moved patch [19,20]/20, in case people are not happy with the changes,
the two patch could be dropped when apply if no v3 patchset.
- Link to v1: https://lore.kernel.org/r/20240501-pinctrl-cleanup-v1-0-797ceca46e5c@nxp.com
---
Peng Fan (20):
pinctrl: ti: iodelay: Use scope based of_node_put() cleanups
pinctrl: tegra: Use scope based of_node_put() cleanups
pinctrl: stm32: Use scope based of_node_put() cleanups
pinctrl: starfive: Use scope based of_node_put() cleanups
pinctrl: sprd: Use scope based of_node_put() cleanups
pinctrl: spear: Use scope based of_node_put() cleanups
pinctrl: renesas: Use scope based of_node_put() cleanups
pinctrl: st: Use scope based of_node_put() cleanups
pinctrl: rockchip: Use scope based of_node_put() cleanups
pinctrl: equilibrium: Use scope based of_node_put() cleanups
pinctrl: at91: Use scope based of_node_put() cleanups
pinctrl: s32cc: Use scope based of_node_put() cleanups
pinctrl: nomadik: Use scope based of_node_put() cleanups
pinctrl: mediatek: Use scope based of_node_put() cleanups
pinctrl: freescale: Use scope based of_node_put() cleanups
pinctrl: bcm: bcm63xx: Use scope based of_node_put() cleanups
pinctrl: pinconf-generic: Use scope based of_node_put() cleanups
pinctrl: freescale: mxs: Fix refcount of child
pinctrl: k210: Use scope based of_node_put() cleanups
pinctrl: samsung: Use scope based of_node_put() cleanups
drivers/pinctrl/bcm/pinctrl-bcm63xx.c | 4 +--
drivers/pinctrl/freescale/pinctrl-imx.c | 25 ++++-----------
drivers/pinctrl/freescale/pinctrl-imx1-core.c | 16 +++-------
drivers/pinctrl/freescale/pinctrl-mxs.c | 18 ++++-------
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 4 +--
drivers/pinctrl/mediatek/pinctrl-paris.c | 4 +--
drivers/pinctrl/nomadik/pinctrl-abx500.c | 4 +--
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 4 +--
drivers/pinctrl/nxp/pinctrl-s32cc.c | 31 ++++++------------
drivers/pinctrl/pinconf-generic.c | 7 ++--
drivers/pinctrl/pinctrl-at91-pio4.c | 7 ++--
drivers/pinctrl/pinctrl-at91.c | 14 +++-----
drivers/pinctrl/pinctrl-equilibrium.c | 21 +++---------
drivers/pinctrl/pinctrl-k210.c | 7 ++--
drivers/pinctrl/pinctrl-rockchip.c | 11 ++-----
drivers/pinctrl/pinctrl-st.c | 37 +++++++---------------
drivers/pinctrl/renesas/pinctrl-rza1.c | 14 +++-----
drivers/pinctrl/renesas/pinctrl-rzg2l.c | 7 ++--
drivers/pinctrl/renesas/pinctrl-rzn1.c | 23 ++++----------
drivers/pinctrl/renesas/pinctrl-rzv2m.c | 7 ++--
drivers/pinctrl/renesas/pinctrl.c | 7 ++--
drivers/pinctrl/samsung/pinctrl-exynos.c | 16 +++-------
drivers/pinctrl/samsung/pinctrl-samsung.c | 19 +++--------
drivers/pinctrl/spear/pinctrl-spear.c | 13 +++-----
drivers/pinctrl/sprd/pinctrl-sprd.c | 14 +++-----
drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c | 27 +++++++---------
drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c | 18 +++++------
drivers/pinctrl/stm32/pinctrl-stm32.c | 4 +--
drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 7 ++--
drivers/pinctrl/tegra/pinctrl-tegra.c | 4 +--
drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 37 ++++++++--------------
31 files changed, 133 insertions(+), 298 deletions(-)
---
base-commit: bb7a2467e6beef44a80a17d45ebf2931e7631083
change-id: 20240429-pinctrl-cleanup-e4d461c32648
Best regards,
--
Peng Fan <peng.fan@....com>
Powered by blists - more mailing lists