linux-kernel - Re: [PATCH] drm/amd/pm: Fix error code in vega10_hwmgr_backend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 4 May 2024 19:13:32 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Dan Carpenter <dan.carpenter@...aro.org>, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, kernel-janitors@...r.kernel.org,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...il.com>,
 Evan Quan <evan.quan@....com>, Jesse Zhang <jesse.zhang@....com>,
 Lijo Lazar <lijo.lazar@....com>, Ma Jun <Jun.Ma2@....com>,
 Tim Huang <Tim.Huang@....com>, Xinhui Pan <Xinhui.Pan@....com>
Cc: LKML <linux-kernel@...r.kernel.org>, Ruan Jinjie <ruanjinjie@...wei.com>
Subject: Re: [PATCH] drm/amd/pm: Fix error code in vega10_hwmgr_backend_init()

> Return -EINVAL on error instead of success.  Also on the success path,
> return a literal zero instead of "return result;"

How do you think about to omit the initialisation for the variable “result”
in another update step?

Regards,
Markus