linux-kernel - Re: [PATCH v5] platform/x86: dell-laptop: Implement platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <S3SXCS.2L4SMU4H4WJF2@lyndeno.ca>
Date: Fri, 03 May 2024 18:59:52 -0600
From: Lyndon Sanche <lsanche@...deno.ca>
To: Armin Wolf <W_Armin@....de>
Cc: mario.limonciello@....com, pali@...nel.org,
	srinivas.pandruvada@...ux.intel.com, ilpo.jarvinen@...ux.intel.com,
	lkp@...el.com, Hans de Goede <hdegoede@...hat.com>, Matthew Garrett
	<mjg59@...f.ucam.org>, Jonathan Corbet <corbet@....net>, Heiner Kallweit
	<hkallweit1@...il.com>, Vegard Nossum <vegard.nossum@...cle.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dell.Client.Kernel@...l.com
Subject: Re: [PATCH v5] platform/x86: dell-laptop: Implement platform_profile



On Fri, May 3 2024 at 11:19:07 PM +02:00:00, Armin Wolf 
<W_Armin@....de> wrote:
> Am 01.05.24 um 23:58 schrieb Lyndon Sanche:
>> +static int thermal_init(void)
>> +{
>> +	int ret;
>> +	int supported_modes;
>> +
>> +	/* If thermal modes not supported, exit without error */
>> +	ret = thermal_get_supported_modes(&supported_modes);
>> +	if (ret < 0)
>> +		return ret;
> 
> Hi,
> 
> some older models might not support the USTT commands, which would 
> prevent dell-laptop
> from loading on such machines.
> Since dell-smbios-base already knows which commands are supported 
> (stored in da_supported_commands),
> maybe you can add a function for checking if a certain class of 
> commands is supported and
> skip thermal_init() if the USTT commands are not supported.
> 
> Thanks,
> Armin Wolf

This is a good idea, I will have a look at dell-smbios-base to see 
exactly how I can check for support. If support is not available, 
thermal_init will skip or return 0 (depending on where I put the check).

Thanks,

Lyndon