linux-kernel - Re: [GIT PULL] tracing/tracefs: Fixes for v6.9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240503212234.71c1cad2@rorschach.local.home>
Date: Fri, 3 May 2024 21:22:34 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Beau Belgrave <beaub@...ux.microsoft.com>
Subject: Re: [GIT PULL] tracing/tracefs: Fixes for v6.9

On Fri, 3 May 2024 17:01:08 -0700
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Fri, 3 May 2024 at 16:07, Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > - Minor fix for user_events interface
> >   The ABI of creating a user event states that the fields
> >   are separated by semicolons, and spaces should be ignored.
> >   But the parsing expected at least one space to be there (which was incorrect).
> >   Fix the reading of the string to handle fields separated by
> >   semicolons but no space between them.  
> 
> This is the opposite of a fix.
> 
> A fix would have fixed the documentation to match reality.
> 
> Instead, this relaxes our existing parsing. Are there any old kernels
> that had that relaxed parsing? Is there any actual reason to not just
> fix documentation to match reality?
> 
> Because when reality and documentation do not match, it is not
> *REALITY* that is buggy.

From what Beau and his team told me was that they had tests that were
failing, and when they looked into it, it was because the tests didn't
include a space after the semicolon.

From what I understand (Beau can correct me) but the semicolon was
supposed to be the delimiter and not a "semicolon followed by one or more
spaces".

-- Steve