linux-kernel - Re: [PATCH] time/timgr: Fix wrong reference when level 0 group allocation failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM7-yPQMDZ9SZPVQExCd2bqTRTzoBVwQUSgrXp=1WSDDOCajag@mail.gmail.com>
Date: Sat, 4 May 2024 05:47:11 +0100
From: Yun Levi <ppbuk5246@...il.com>
To: anna-maria@...utronix.de, frederic@...nel.org, tglx@...utronix.de
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] time/timgr: Fix wrong reference when level 0 group
 allocation failed

Gentle ping

On Wed, May 1, 2024 at 8:51 PM Levi Yun <ppbuk5246@...il.com> wrote:
>
> When tmigr_setup_groups() failed level 0 group allocation,
> next do while loop refers wrong local stack array location.
>
> Changing group init do while loop with while loop to fix this problem.
>
> Signed-off-by: Levi Yun <ppbuk5246@...il.com>
> ---
>  kernel/time/timer_migration.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c
> index ccba875d2234..84413114db5c 100644
> --- a/kernel/time/timer_migration.c
> +++ b/kernel/time/timer_migration.c
> @@ -1596,7 +1596,7 @@ static int tmigr_setup_groups(unsigned int cpu, unsigned int node)
>
>         } while (i < tmigr_hierarchy_levels);
>
> -       do {
> +       while (i > 0) {
>                 group = stack[--i];
>
>                 if (err < 0) {
> @@ -1645,7 +1645,7 @@ static int tmigr_setup_groups(unsigned int cpu, unsigned int node)
>                                 tmigr_connect_child_parent(child, group);
>                         }
>                 }
> -       } while (i > 0);
> +       }
>
>         kfree(stack);
>
> --
> 2.41.0
>