linux-kernel - RE: [PATCH v3] selftests/vDSO: Explicit unsigned char conversion for elf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 5 May 2024 13:20:35 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Justin Stitt' <justinstitt@...gle.com>, Edward Liaw <edliaw@...gle.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Shuah Khan
	<shuah@...nel.org>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers
	<ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>, "H. Peter Anvin"
	<hpa@...ux.intel.com>, Andy Lutomirski <luto@....edu>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
	"kernel-team@...roid.com" <kernel-team@...roid.com>, "llvm@...ts.linux.dev"
	<llvm@...ts.linux.dev>
Subject: RE: [PATCH v3] selftests/vDSO: Explicit unsigned char conversion for
 elf_hash

From: Justin Stitt
> Sent: 01 May 2024 20:55
..
> > static unsigned long elf_hash(const unsigned char *name)
..
> Is it possible to just change the types of the parameters of vdso_sym()
> or does that trigger even more warnings on the callsites of vdso_sym()?

Isn't the problem the definition of elf_hash()?
A '\0' terminated string really ought to be 'char *' not 'unsigned char *'.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)