linux-kernel - Re: [PATCH v3 1/2] dt-bindings: media: i2c: add galaxycore,gc2145 DVP bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 5 May 2024 12:23:28 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Andrey Skvortsov <andrej.skvortzov@...il.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Alain Volmat <alain.volmat@...s.st.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring
 <robh+dt@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
 linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Ondřej Jirman <megi@....cz>,
 Pavel Machek <pavel@....cz>, Arnaud Ferraris <arnaud.ferraris@...labora.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: media: i2c: add galaxycore,gc2145 DVP
 bus support

On 05/05/2024 11:04, Andrey Skvortsov wrote:
> Hi Krzysztof,
> 
> On 24-05-05 10:20, Krzysztof Kozlowski wrote:
>> On 04/05/2024 18:41, Andrey Skvortsov wrote:
>>> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@...il.com>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
>> Not true. I never acked patch with empty commit and such content.
>>
> Sorry about that. You've acked v1, so I've kept it. I'll remove it in
> v4.

I acked entirely different version. It had even commit msg. Empty commit
would have never been acked.

> 
>> Drop fake tag and send new version with proper commit msg and proper
>> changelog under ---.
> There is changelog in cover letter. Should I include corresponding changelog in each
> patch as well?

It's fine there although nothing explains why you did these changes or
why commit msg is gone.

Best regards,
Krzysztof