linux-kernel - Re: Bluetooth: qca: Use common error handling code in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 5 May 2024 12:37:05 +0200 (CEST)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Markus Elfring <Markus.Elfring@....de>
cc: Luiz Augusto von Dentz <luiz.dentz@...il.com>, 
    Marcel Holtmann <marcel@...tmann.org>, linux-bluetooth@...r.kernel.org, 
    kernel-janitors@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: Bluetooth: qca: Use common error handling code in two
 functions



On Sun, 5 May 2024, Markus Elfring wrote:

> >> Add a jump target so that the setting of an error code can be better reused
> >> at the end of these function implementations.
> …
> > This reduces readability, and backwards jumps are rarely desirable.
>
> Would you like to support any other design approaches better for
> the reduction of questionable source code duplication?

Maybe cleanup.h can be used to get rid of the kfree_skb.  I have no idea.

It would be nice to keep the patch in the message so that one could see
what is being discussed from the message itself.

julia