linux-kernel - Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 6 May 2024 10:25:34 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.de>
Cc: Jaroslav Kysela <perex@...ex.cz>, Shuah Khan <shuah@...nel.org>,
 Takashi Iwai <tiwai@...e.com>, Ivan Orlov <ivan.orlov0322@...il.com>,
 linux-sound@...r.kernel.org, Valentin Obst <kernel@...entinobst.de>,
 linux-kselftest@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 llvm@...ts.linux.dev
Subject: Re: [PATCH v2] selftests/alsa: missing a return value in unused
 dump_config_tree()

On 5/6/24 7:44 AM, Mark Brown wrote:
> On Mon, May 06, 2024 at 09:45:21AM +0200, Takashi Iwai wrote:
>> Jaroslav Kysela wrote:
> 
>>> This function is nice for debugging. I'd prefer to keep it with the fix.
> 
>> I'm find in either way; just submit a fix patch, then.
> 
> The fix was already submitted as v1, I noticed that the function was
> unused in review.

It's generally considered a best practice to delete unused code. If
there is something you especially like for upcoming code, you still
have git history, and even a lore.kernel.org link, to bookmark it.

So I'd recommend going with v2, but of course it's your call! :)


thanks,
-- 
John Hubbard
NVIDIA