linux-kernel - Re: [PATCH] clocksource/drivers/arm_arch_timer: Mark hisi_161010101_oem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ead7324b-3cc1-15da-d80f-ef5ea1bec218@huawei.com>
Date: Mon, 6 May 2024 09:03:03 +0800
From: Hanjun Guo <guohanjun@...wei.com>
To: Stephen Boyd <swboyd@...omium.org>, Daniel Lezcano
	<daniel.lezcano@...aro.org>, Thomas Gleixner <tglx@...utronix.de>
CC: <linux-kernel@...r.kernel.org>, <patches@...ts.linux.dev>,
	<linux-arm-kernel@...ts.infradead.org>, dann frazier
	<dann.frazier@...onical.com>, Hanjun Guo <hanjun.guo@...aro.org>, Marc
 Zyngier <maz@...nel.org>, Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] clocksource/drivers/arm_arch_timer: Mark
 hisi_161010101_oem_info const

On 2024/5/3 7:34, Stephen Boyd wrote:
> This isn't modified at runtime. Mark it const so it can move to
> read-only data.
> 
> Cc: dann frazier <dann.frazier@...onical.com>
> Cc: Hanjun Guo <hanjun.guo@...aro.org>
> Cc: Marc Zyngier <maz@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>   drivers/clocksource/arm_arch_timer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index 8d4a52056684..5bb43cc1a8df 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -331,7 +331,7 @@ static u64 notrace hisi_161010101_read_cntvct_el0(void)
>   	return __hisi_161010101_read_reg(cntvct_el0);
>   }
>   
> -static struct ate_acpi_oem_info hisi_161010101_oem_info[] = {
> +static const struct ate_acpi_oem_info hisi_161010101_oem_info[] = {
>   	/*
>   	 * Note that trailing spaces are required to properly match
>   	 * the OEM table information.

Looks good to me,

Reviewed-by: Hanjun Guo <guohanjun@...wei.com>