linux-kernel - Re: [PATCH v2 3/3] Input: ektf2127

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 6 May 2024 22:29:16 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: dmitry.torokhov@...il.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, u.kleine-koenig@...gutronix.de, hdegoede@...hat.com,
 siebren.vroegindeweij@...mail.com, linux-input@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] Input: ektf2127 - add ektf2232 support

On Mon, 6 May 2024 21:43:14 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Mon, May 6, 2024 at 7:21 PM Andreas Kemnade <andreas@...nade.info> wrote:
> > On Mon, 6 May 2024 15:05:52 +0300
> > Andy Shevchenko <andy.shevchenko@...il.com> wrote:  
> > > From: Andy Shevchenko <andy.shevchenko@...il.com>
> > > To: Andreas Kemnade <andreas@...nade.info>
> > > Date: Mon, 6 May 2024 15:05:52 +0300
> > > On Mon, May 6, 2024 at 12:48 AM Andreas Kemnade <andreas@...nade.info> wrote:  
> 
> ...
> 
> > > I'm wondering if you are using --histogram diff algo when preparing the patches.  
> >
> > No, I am not using that, it seems to not make that chunk nicer.
> > Yes, we want
> >
> > +       int status_shift;
> >  };
> > +
> > +struct ektf2127_i2c_chip_data {
> > +       int status_shift;
> > +};
> >
> > But that is not shorter or simpler, just more readable.  
> 
> And that's exactly what histogram is about. I suggest making it
> default for the Linux kernel project (or globally in your
> ~/.gitconfig).
> 
> 
again, it does not do anything helpful in this case, I tried to run
git format-patch --histogram with
no improvements. But it might help in other places.

Regards,
Andreas