linux-kernel - Re: [PATCH] scsi:iscsi: Remove unused list 'connlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1b142bc-50e4-4117-945a-7d74dad763d8@oracle.com>
Date: Mon, 6 May 2024 15:52:12 -0500
From: Mike Christie <michael.christie@...cle.com>
To: linux@...blig.org, James.Bottomley@...senPartnership.com
Cc: linux-kernel@...r.kernel.org, open-iscsi@...glegroups.com,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH] scsi:iscsi: Remove unused list 'connlist_err'

On 5/3/24 6:23 PM, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> I think the last use of this list was removed by
>   commit 23d6fefbb3f6 ("scsi: iscsi: Fix in-kernel conn failure
> handling").
> 
> Build tested only.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>  drivers/scsi/scsi_transport_iscsi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index af3ac6346796b..123b861d2a9fb 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -1603,7 +1603,6 @@ static DEFINE_MUTEX(rx_queue_mutex);
>  static LIST_HEAD(sesslist);
>  static DEFINE_SPINLOCK(sesslock);
>  static LIST_HEAD(connlist);
> -static LIST_HEAD(connlist_err);
>  static DEFINE_SPINLOCK(connlock);
>  
>  static uint32_t iscsi_conn_get_sid(struct iscsi_cls_conn *conn)

Reviewed-by: Mike Christie <michael.christie@...cle.com>