linux-kernel - Re: [PATCH v2 1/1] dm-delay: fix hung task introduced by kthread mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZjlHY02it0wBL0TB@redhat.com>
Date: Mon, 6 May 2024 17:10:59 -0400
From: Benjamin Marzinski <bmarzins@...hat.com>
To: Joel Colledge <joel.colledge@...bit.com>
Cc: Christian Loehle <christian.loehle@....com>, dm-devel@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] dm-delay: fix hung task introduced by kthread mode

On Mon, May 06, 2024 at 09:25:23AM +0200, Joel Colledge wrote:
> If the worker thread is not woken due to a bio, then it is not woken at
> all. This causes the hung task check to trigger. This occurs, for
> instance, when no bios are submitted. Also when a delay of 0 is
> configured, delay_bio() returns without waking the worker.
> 
> Prevent the hung task check from triggering by creating the thread with
> kthread_run() instead of using kthread_create() directly.
> 
> Fixes: 70bbeb29fab0 ("dm delay: for short delays, use kthread instead of timers and wq")
> Signed-off-by: Joel Colledge <joel.colledge@...bit.com>

Reviewed-by: Benjamin Marzinski <bmarzins@...hat.com>