linux-kernel - Re: [RFT PATCH v2 46/48] drm/panel: sony-acx565akm: Don't double-check enabled state in disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdarbyhZufTHy1m57rfVdMO9aqbgkoHfdhG3h0=RZTjV8g@mail.gmail.com>
Date: Mon, 6 May 2024 08:49:03 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Douglas Anderson <dianders@...omium.org>
Cc: dri-devel@...ts.freedesktop.org, Maxime Ripard <mripard@...nel.org>, 
	Chris Morgan <macromorgan@...mail.com>, Yuran Pereira <yuran.pereira@...mail.com>, 
	Neil Armstrong <neil.armstrong@...aro.org>, 
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
	Sebastian Reichel <sebastian.reichel@...labora.com>, Daniel Vetter <daniel@...ll.ch>, 
	David Airlie <airlied@...il.com>, Jessica Zhang <quic_jesszhan@...cinc.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Sam Ravnborg <sam@...nborg.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [RFT PATCH v2 46/48] drm/panel: sony-acx565akm: Don't
 double-check enabled state in disable

On Fri, May 3, 2024 at 11:38 PM Douglas Anderson <dianders@...omiumorg> wrote:

> As talked about in commit d2aacaf07395 ("drm/panel: Check for already
> prepared/enabled in drm_panel"), we want to remove needless code from
> panel drivers that was storing and double-checking the
> prepared/enabled state. Even if someone was relying on the
> double-check before, that double-check is now in the core and not
> needed in individual drivers.
>
> The acx565akm seems to do some unique stuff with the "enabled"
> state. Specifically:
> 1. It seems to detect the enabled state based on how the bootloader
>    left the panel.
> 2. It uses the enabled state to prevent certain sysfs files from
>    accessing a disabled panel.
>
> We'll leave the "enabled" state tracking for this. However, we can at
> least get rid of the double-check when trying to disable.
>
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Cc: Sebastian Reichel <sebastian.reichel@...labora.com>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij