linux-kernel - Re: [PATCH] i3c: dw: Disable IBI IRQ depends on hot-join and SIR enabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52f4e4afef87c336f054ca1c43eec58d2e44a5b1.camel@codeconstruct.com.au>
Date: Mon, 06 May 2024 14:58:06 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Dylan Hung <dylan_hung@...eedtech.com>, "alexandre.belloni@...tlin.com"
 <alexandre.belloni@...tlin.com>, "joel@....id.au" <joel@....id.au>, 
 "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
 "gustavoars@...nel.org" <gustavoars@...nel.org>,
 "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
 "zenghuchen@...gle.com" <zenghuchen@...gle.com>,
 "matt@...econstruct.com.au" <matt@...econstruct.com.au>, 
 "linux-i3c@...ts.infradead.org" <linux-i3c@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: BMC-SW <BMC-SW@...eedtech.com>
Subject: Re: [PATCH] i3c: dw: Disable IBI IRQ depends on hot-join and SIR
 enabling

Hi Dylan,

> > The initial state would be to have all SIRs masked.
> > 
> 
> Yes, indeed. The "global" variable is also true because "reg ==
> 0xffffffff" is true.
> Therefore, the INTR_IBI_THLD_STAT bit will be set in the following
> code.

That's mainly my point - none of this code is ever run unless the
->enable_ibi or ->disable_ibi controller callback is invoked.

So we'll end up with the HJ interrupt only being enabled if some i3c
device driver enables IBIs, which is a bit of a weird side-effect.

It probably makes more sense when the rest of the HJ code is added, but
not so much as a standalone patch.

Cheers,


Jeremy