linux-kernel - Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 06 May 2024 09:45:21 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Jaroslav Kysela <perex@...ex.cz>
Cc: Takashi Iwai <tiwai@...e.de>,
	John Hubbard <jhubbard@...dia.com>,
	Shuah Khan <shuah@...nel.org>,
	Mark Brown <broonie@...nel.org>,
	Takashi Iwai <tiwai@...e.com>,
	Ivan Orlov <ivan.orlov0322@...il.com>,
	linux-sound@...r.kernel.org,
	Valentin Obst <kernel@...entinobst.de>,
	linux-kselftest@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	llvm@...ts.linux.dev
Subject: Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree()

On Mon, 06 May 2024 09:27:38 +0200,
Jaroslav Kysela wrote:
> 
> On 06. 05. 24 9:19, Takashi Iwai wrote:
> > On Sun, 05 May 2024 23:08:24 +0200,
> > John Hubbard wrote:
> >> 
> >> dump_config_tree() is declared to return an int, but the compiler cannot
> >> prove that it always returns any value at all. This leads to a clang
> >> warning, when building via:
> >> 
> >>      make LLVM=1 -C tools/testing/selftests
> >> 
> >> Furthermore, Mark Brown noticed that dump_config_tree() isn't even used
> >> anymore, so just delete the entire function.
> >> 
> >> Cc: Mark Brown <broonie@...nel.org>
> >> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> > 
> > Thanks, applied now.
> 
> This function is nice for debugging. I'd prefer to keep it with the fix.

I'm find in either way; just submit a fix patch, then.


thanks,

Takashi