linux-kernel - Re: [PATCH net-next] net: phy: add wol config options in phy device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 6 May 2024 03:28:33 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
Cc: netdev@...r.kernel.org, lxu@...linear.com, hkallweit1@...il.com,
	linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org,
	UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next] net: phy: add wol config options in phy device

> One quick question.
> some of the options (ex. WAKE_PHY, WAKE_MAGIC etc) support on PHY and other
> options (ex. WAKE_UCAST, WAKE_MAGICSECURE etc) on MAC of Ethernet device.
> 
> Suppose, user configure the combination (i.e. wol gu) option,
> Is PHY flag should hold combination option or only PHY supported option ?

I don't think it actually matters. The user is going to end up
invoking the PHY set wol. The PHY will setup what it can. On resume
you are going to call the PHYs set wol function again. It should do
the same as it did the first time. So if the PHY ignored WAKE_UCAST
and WAKE_MAGICSECURE the first time, it should also ignore them the
second time.

> Ok. I will change.
> May be in phy_init_hw( ) function is better place to re-config the WOL

You should first answer Russell question. It could be a totally
different scheme might come of of the discussion with Russell.

	  Andrew