linux-kernel - Re: [EXTERNAL] Re: [PATCH v3 1/3] ALSA: hda/tas2781: Modification for add tas2781 driver for SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjiYflatVz7F_2em@smile.fi.intel.com>
Date: Mon, 6 May 2024 11:44:46 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: "Xu, Baojun" <baojun.xu@...com>
Cc: "tiwai@...e.de" <tiwai@...e.de>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"perex@...ex.cz" <perex@...ex.cz>,
	"pierre-louis.bossart@...ux.intel.com" <pierre-louis.bossart@...ux.intel.com>,
	"Lu, Kevin" <kevin-lu@...com>,
	"Ding, Shenghao" <shenghao-ding@...com>,
	"Navada Kanyana, Mukund" <navada@...com>,
	"13916275206@....com" <13916275206@....com>,
	"P O, Vijeth" <v-po@...com>,
	"Holalu Yogendra, Niranjan" <niranjan.hy@...com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
	"yung-chuan.liao@...ux.intel.com" <yung-chuan.liao@...ux.intel.com>,
	"broonie@...nel.org" <broonie@...nel.org>,
	"soyer@....hu" <soyer@....hu>
Subject: Re: [EXTERNAL] Re: [PATCH v3 1/3] ALSA: hda/tas2781: Modification
 for add tas2781 driver for SPI

On Mon, May 06, 2024 at 07:44:05AM +0000, Xu, Baojun wrote:
> > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Sent: 02 May 2024 18:22
> > To: Xu, Baojun
> > On Thu, Apr 25, 2024 at 07: 54: 41AM +0000, Xu, Baojun wrote:
> > On Thu, Apr 25, 2024 at 07:54:41AM +0000, Xu, Baojun wrote:
> > > > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > > Sent: 18 April 2024 19:56
> > > > On Thu, Apr 18, 2024 at 12: 02: 37PM +0800, Baojun Xu wrote:
> > > > On Thu, Apr 18, 2024 at 12:02:37PM +0800, Baojun Xu wrote:

..

> > > > >  sound/pci/hda/Kconfig                           | 15 +++++++++++++++
> > > > >  sound/pci/hda/Makefile                          |  2 ++
> > > >
> > > Is this correct? You are adding a dead "code", isn't it?
> > >
> > > What's mean "dead code"? After add CONFIG_SND_HDA_SCODEC_TAS2781_SPI=m
> > > in my config file, the whole patch code has worked.
> > 
> > Is that file already in the repository?
> > If not, I don't see it in this patch either --> dead code.
> 
> When I integrated CONFIG_SND_HDA_SCODEC_TAS2781_SPI and compiled the whole kernel,
> it used to popup the following message for TAS2781 SPI module in first compile:
>  
>  Build TAS2781 HD-audio side codec support for SPI Bus (SND_HDA_SCODEC_TAS2781_SPI) [N/m/?] (NEW) 
> 
> Normally, selected m. And TAS2781 SPI module would be compiled.

The above is a dead code if this SPI driver is not yet in the kernel. Is it?
What is the path to it in the current kernel source tree?

-- 
With Best Regards,
Andy Shevchenko