linux-kernel - Re: [v5 3/3] KVM: s390: don't setup dummy routing when KVM_CREATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f586a9e-2982-497a-8674-cd788f2e8308@linux.ibm.com>
Date: Mon, 6 May 2024 13:42:11 +0200
From: Christian Borntraeger <borntraeger@...ux.ibm.com>
To: Yi Wang <up2wing@...il.com>, seanjc@...gle.com, pbonzini@...hat.com,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        wanpengli@...cent.com, foxywang@...cent.com, oliver.upton@...ux.dev,
        maz@...nel.org, anup@...infault.org, atishp@...shpatra.org,
        frankja@...ux.ibm.com, imbrenda@...ux.ibm.com, weijiang.yang@...el.com
Subject: Re: [v5 3/3] KVM: s390: don't setup dummy routing when
 KVM_CREATE_IRQCHIP



Am 06.05.24 um 12:17 schrieb Yi Wang:
> From: Yi Wang <foxywang@...cent.com>
> 
> As we have setup empty irq routing in kvm_create_vm(), there's
> no need to setup dummy routing when KVM_CREATE_IRQCHIP.
> 
> Signed-off-by: Yi Wang <foxywang@...cent.com>

Acked-by: Christian Borntraeger <borntraeger@...ux.ibm.com>


> ---
>   arch/s390/kvm/kvm-s390.c | 9 +--------
>   1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 5147b943a864..ba7fd39bcbf4 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -2998,14 +2998,7 @@ int kvm_arch_vm_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg)
>   		break;
>   	}
>   	case KVM_CREATE_IRQCHIP: {
> -		struct kvm_irq_routing_entry routing;
> -
> -		r = -EINVAL;
> -		if (kvm->arch.use_irqchip) {
> -			/* Set up dummy routing. */
> -			memset(&routing, 0, sizeof(routing));
> -			r = kvm_set_irq_routing(kvm, &routing, 0, 0);
> -		}
> +		r = 0;
>   		break;
>   	}
>   	case KVM_SET_DEVICE_ATTR: {