linux-kernel - Re: [PATCH] media: verisilicon: AV1: Be more fexible on postproc capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c747a5e6-e3f2-4bea-87e2-92b71501db9a@collabora.com>
Date: Mon, 6 May 2024 16:38:53 +0200
From: Benjamin Gaignard <benjamin.gaignard@...labora.com>
To: Nicolas Dufresne <nicolas@...fresne.ca>, ezequiel@...guardiasur.com.ar,
 p.zabel@...gutronix.de, mchehab@...nel.org, heiko@...ech.de
Cc: linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 kernel@...labora.com
Subject: Re: [PATCH] media: verisilicon: AV1: Be more fexible on postproc
 capabilities


Le 05/04/2024 à 10:17, Benjamin Gaignard a écrit :
>
> Le 04/04/2024 à 19:59, Nicolas Dufresne a écrit :
>> Hi,
>>
>> Le jeudi 28 mars 2024 à 10:34 +0100, Benjamin Gaignard a écrit :
>>> RK3588 post-processor block is able to convert 10 bits streams
>>> into 8 bits pixels format.
>> Does it come with any HDR to SDR capabilities ? cause stripping off 2 
>> bits means
>> that tone mapping will cause a lot of banding as it won't have the 
>> expected
>> precision. I'm simply trying to make up the big portrait so we don't 
>> just offer
>> yet another foot gun. But perhaps its fine to offer this, its just 
>> that we don't
>> have a mechanism to report which pixel format in the selection will 
>> cause data
>> lost.
>
> No it just to enable post-processor capabilities like we have already 
> for G2/HEVC.
> Since it is a post-processor pixel format it will be enumerated after 
> V4L2_PIX_FMT_NV15_4L4
> so it will update to userland to decide to use it or not.

Gentle ping,
Regards,
Benjamin

>
> Benjamin
>
>>
>> Nicolas
>>
>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...labora.com>
>>> Fixes: 003afda97c65 ("media: verisilicon: Enable AV1 decoder on 
>>> rk3588")
>>> ---
>>>   drivers/media/platform/verisilicon/rockchip_vpu_hw.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/media/platform/verisilicon/rockchip_vpu_hw.c 
>>> b/drivers/media/platform/verisilicon/rockchip_vpu_hw.c
>>> index f97527670783..964122e7c355 100644
>>> --- a/drivers/media/platform/verisilicon/rockchip_vpu_hw.c
>>> +++ b/drivers/media/platform/verisilicon/rockchip_vpu_hw.c
>>> @@ -82,7 +82,6 @@ static const struct hantro_fmt 
>>> rockchip_vpu981_postproc_fmts[] = {
>>>       {
>>>           .fourcc = V4L2_PIX_FMT_NV12,
>>>           .codec_mode = HANTRO_MODE_NONE,
>>> -        .match_depth = true,
>>>           .postprocessed = true,
>>>           .frmsize = {
>>>               .min_width = ROCKCHIP_VPU981_MIN_SIZE,
>>