linux-kernel - Re: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with both fixed and adjustable vout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjjwFTtiopqsYdeJ@finisterre.sirena.org.uk>
Date: Mon, 6 May 2024 23:58:29 +0900
From: Mark Brown <broonie@...nel.org>
To: Alina Yu <alina_yu@...htek.com>
Cc: lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	johnny_lai@...htek.com, cy_huang@...htek.com
Subject: Re: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with
 both fixed and adjustable vout

On Fri, May 03, 2024 at 03:35:36PM +0800, Alina Yu wrote:
> On Fri, May 03, 2024 at 10:41:04AM +0900, Mark Brown wrote:

> > That's a substantail reconfiguration of the regulator, it would be
> > better to have an explicit property for these non-standard fixed
> > voltages rather than trying to do this using constraints, or at the very
> > least have validation that the values being set are supported by the
> > hardware.  The code should also be very clear about what is going on.

> May I add the 'richtek,use-fix-dvs' property back ?

It sounds like it might be better to add a property specifying the
specific fixed voltage rather than overloading the constraints for this
purpose.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)