linux-kernel - Re: [PATCH v5 linux-next] usb:typec:mux: remove indentation for common path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <da7a6e8c-fdda-42d3-ad42-c34e585d0ef8@gmail.com>
Date: Mon, 6 May 2024 21:39:43 +0530
From: R Sundar <prosunofficial@...il.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: gregkh@...uxfoundation.org, neil.armstrong@...aro.org,
 dmitry.baryshkov@...aro.org, u.kleine-koenig@...gutronix.de,
 christophe.jaillet@...adoo.fr, linux-usb@...r.kernel.org,
 linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
 javier.carrasco.cruz@...il.com
Subject: Re: [PATCH v5 linux-next] usb:typec:mux: remove indentation for
 common path

Hi Heikki,

On 06/05/24 14:29, Heikki Krogerus wrote:
> Hi Sundar,
> 
> On Fri, Apr 26, 2024 at 10:17:05PM +0530, R Sundar wrote:
>> Nitpick, Mostly common path will not be indented.  so rewritten this
>> function to check device_node pointer is null and removed common path
>> indentation.
>>
>> Signed-off-by: R Sundar <prosunofficial@...il.com>
> 
> For the record, I'm still uncomfortable with the name - why not just
> spell out your whole name?
> 

I understand your concern.  " R Sundar ",  is my whole name.

>> ---
>>
>> Fixed nitpicks in code according to comments received on other patch as
>> below:
>>
> 
> Sorry for missing this earlier, but it looks like this patch only
> modifies the nb7vpq904m driver, so I think you should specify that
> already in the subject.
> While at it, you could also specify the only function that is being
> modified in the commit message (this is just a suggestion):
> 
>          usb: typec: nb7vpq904m: Remove uneeded indentation
> 
>          In function nb7vpq904m_parse_data_lanes_mapping(), the "if
>          (ep)" condition is basically the entire function. Making the
>          code a bit more readable by inverting the condition so that
>          the function returns immedately if there is no "ep".
> 
> thanks,
> 

Thanks for the suggestion provided,  will modify the commit message and 
send the updated one.


Thanks,
Sundar