linux-kernel - Re: [PATCH v4 1/3] mm/rmap: remove duplicated exit code in pagewalk loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 07 May 2024 10:51:29 -0400
From: Zi Yan <ziy@...dia.com>
To: Lance Yang <ioworker0@...il.com>
Cc: akpm@...ux-foundation.org, willy@...radead.org, sj@...nel.org,
 maskray@...gle.com, ryan.roberts@....com, david@...hat.com,
 21cnbao@...il.com, mhocko@...e.com, fengwei.yin@...el.com,
 zokeefe@...gle.com, shy828301@...il.com, xiehuan09@...il.com,
 libang.li@...group.com, wangkefeng.wang@...wei.com, songmuchun@...edance.com,
 peterx@...hat.com, minchan@...nel.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] mm/rmap: remove duplicated exit code in pagewalk
 loop

On 1 May 2024, at 0:26, Lance Yang wrote:

> Introduce the labels walk_done and walk_done_err as exit points to
> eliminate duplicated exit code in the pagewalk loop.
>
> Signed-off-by: Lance Yang <ioworker0@...il.com>
> ---
>  mm/rmap.c | 40 +++++++++++++++-------------------------
>  1 file changed, 15 insertions(+), 25 deletions(-)

LGTM. Reviewed-by: Zi Yan <ziy@...dia.com>
--
Best Regards,
Yan, Zi

Download attachment "signature.asc" of type "application/pgp-signature" (855 bytes)