linux-kernel - Re: [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f44c76ac-3dc1-45d6-b435-e5b77b708d6e@cherry.de>
Date: Tue, 7 May 2024 18:48:46 +0200
From: Quentin Schulz <quentin.schulz@...rry.de>
To: Heiko Stuebner <heiko@...ech.de>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org
Cc: andy.yan@...k-chips.com, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Heiko Stuebner <heiko.stuebner@...rry.de>
Subject: Re: [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon

Hi Heiko,

On 5/6/24 2:46 PM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@...rry.de>
> 
> RK3588 CSI and DSI support requires the GRF for DC-PHY.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@...rry.de>
> ---
>   Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 0b87c266760c6..0131c62893450 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -22,6 +22,7 @@ properties:
>                 - rockchip,rk3568-usb2phy-grf
>                 - rockchip,rk3588-bigcore0-grf
>                 - rockchip,rk3588-bigcore1-grf
> +              - rockchip,rk3588-dcphy-grf

There are two. While the TRM states:

"""
There are two MIPICDPHY_GRF modules in RK3588.They have different base 
address.
"""

(ignore the typo :) )

it states the same for the bigcore grf but we have two bindings for them 
in there... So not sure what to go for here? Similarly, pipe-grf has 
three instances but we define only one binding...

So who knows :)

That being said,
Reviewed-by: Quentin Schulz <quentin.schulz@...rry.de>

Thanks!
Quentin