linux-kernel - Re: [PATCH V3 net 1/7] net: hns3: using user configure after hardware reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73a1dc2e-cd7c-4fb0-a2cd-181155776490@web.de>
Date: Tue, 7 May 2024 18:51:40 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Jijie Shao <shaojijie@...wei.com>, Peiyang Wang
 <wangpeiyang1@...wei.com>, netdev@...r.kernel.org,
 kernel-janitors@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Jiri Pirko <jiri@...nulli.us>, Paolo Abeni <pabeni@...hat.com>,
 Salil Mehta <salil.mehta@...wei.com>, Simon Horman <horms@...nel.org>,
 Yisen Zhuang <yisen.zhuang@...wei.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Hao Chen <chenhao418@...wei.com>,
 Jie Wang <wangjie125@...wei.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Yonglong Liu <liuyonglong@...wei.com>
Subject: Re: [PATCH V3 net 1/7] net: hns3: using user configure after hardware
 reset

Can any wording adjustments be a bit nicer?

> When a reset occurring, it's supposed to recover user's configuration.

An user configuration should be recovered after a reset occurred.

…
> and will be scheduled updated. Consider the case that reset was happened

and the schedule will be updated. Consider also the case that reset happened

…
> To avoid aboved situation, this patch introduced …

* Would you like to avoid another typo here?

* How do you think about to use imperative wordings for improved change descriptions?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc7#n94

Regards,
Markus