linux-kernel - Re: [PATCH v4] fs/coredump: Enable dynamic configuration of max file note size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <171510137055.3977159.13112533071742599257.b4-ty@chromium.org>
Date: Tue,  7 May 2024 10:02:53 -0700
From: Kees Cook <keescook@...omium.org>
To: linux-fsdevel@...r.kernel.org,
	Allen Pais <apais@...ux.microsoft.com>
Cc: Kees Cook <keescook@...omium.org>,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	viro@...iv.linux.org.uk,
	brauner@...nel.org,
	jack@...e.cz,
	ebiederm@...ssion.com,
	mcgrof@...nel.org,
	j.granados@...sung.com,
	allen.lkml@...il.com
Subject: Re: [PATCH v4] fs/coredump: Enable dynamic configuration of max file note size

On Mon, 06 May 2024 19:37:00 +0000, Allen Pais wrote:
> Introduce the capability to dynamically configure the maximum file
> note size for ELF core dumps via sysctl.
> 
> Why is this being done?
> We have observed that during a crash when there are more than 65k mmaps
> in memory, the existing fixed limit on the size of the ELF notes section
> becomes a bottleneck. The notes section quickly reaches its capacity,
> leading to incomplete memory segment information in the resulting coredump.
> This truncation compromises the utility of the coredumps, as crucial
> information about the memory state at the time of the crash might be
> omitted.
> 
> [...]

I adjusted file names, but put it in -next. I had given some confusing
feedback on v3, but I didn't realize until later; apologies for that! The
end result is the sysctl is named kernel.core_file_note_size_limit and
the internal const min/max variables have the _min and _max suffixes.

Applied to for-next/execve, thanks!

[1/1] fs/coredump: Enable dynamic configuration of max file note size
      https://git.kernel.org/kees/c/81e238b1299e

Take care,

-- 
Kees Cook