linux-kernel - Re: [PATCH 12/13] regulator: add pm8008 pmic regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 7 May 2024 20:22:34 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Johan Hovold <johan@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: Johan Hovold <johan+linaro@...nel.org>, Lee Jones <lee@...nel.org>, 
	Mark Brown <broonie@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Liam Girdwood <lgirdwood@...il.com>, Das Srinagesh <quic_gurus@...cinc.com>, 
	Satya Priya <quic_c_skakit@...cinc.com>, Stephen Boyd <swboyd@...omium.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 12/13] regulator: add pm8008 pmic regulator driver

On Tue, May 7, 2024 at 6:44 PM Johan Hovold <johan@...nel.org> wrote:
> On Mon, May 06, 2024 at 10:09:50PM +0300, Andy Shevchenko wrote:
> > Mon, May 06, 2024 at 05:08:29PM +0200, Johan Hovold kirjoitti:

..

> > > [ johan: rework probe to match new binding, amend commit message and
> > >          Kconfig entry]
> >
> > Wouldn't be better on one line?
>
> Now you're really nit picking. ;) I think I prefer to stay within 72
> columns.

Not really. The tag block is special and the format is rather one
entry per line. This might break some scriptings.

..

> > > +#include <linux/kernel.h>
> >
> > What is this header for?
>
> Probably the ones that are not explicitly included.

Please, remove it, it's a mess nowadays and most of what you need is
available via other headers.

..

> >                       return dev_err_probe(...);
>
> Nah, regmap won't trigger a probe deferral.

And it doesn't matter. What we gain with dev_err_probe() is:
- special handling of deferred probe
- unified format of messages in ->probe() stage

The second one is encouraged.

..

> > > +MODULE_ALIAS("platform:qcom-pm8008-regulator");
> >
> > Use ID table instead.
>
> No, the driver is not using an id-table for matching so the alias is
> needed for module auto-loading.

Then create one. Added Krzysztof for that. (He is working on dropping
MODULE_ALIAS() in cases like this one)

-- 
With Best Regards,
Andy Shevchenko