linux-kernel - Re: [PATCH V2 3/9] tools/perf: Fix a comment about multi_regs in extract_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 6 May 2024 21:40:15 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
Cc: acme@...nel.org, jolsa@...nel.org, adrian.hunter@...el.com, 
	irogers@...gle.com, segher@...nel.crashing.org, christophe.leroy@...roup.eu, 
	linux-perf-users@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, 
	maddy@...ux.ibm.com, kjain@...ux.ibm.com, disgoel@...ux.vnet.ibm.com, 
	linux-kernel@...r.kernel.org, akanksha@...ux.ibm.com
Subject: Re: [PATCH V2 3/9] tools/perf: Fix a comment about multi_regs in
 extract_reg_offset function

On Mon, May 6, 2024 at 5:19 AM Athira Rajeev
<atrajeev@...ux.vnet.ibm.com> wrote:
>
> Fix a comment in function which explains how multi_regs field gets set
> for an instruction. In the example, "mov  %rsi, 8(%rbx,%rcx,4)", the
> comment mistakenly referred to "dst_multi_regs = 0". Correct it to use
> "src_multi_regs = 0"
>
> Signed-off-by: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung

> ---
>  tools/perf/util/annotate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index f5b6b5e5e757..0f5e10654d09 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -2093,7 +2093,7 @@ static int extract_reg_offset(struct arch *arch, const char *str,
>   *   mov  0x18, %r8      # src_reg1 = -1, src_mem = 0
>   *                       # dst_reg1 = r8, dst_mem = 0
>   *
> - *   mov  %rsi, 8(%rbx,%rcx,4)  # src_reg1 = rsi, src_mem = 0, dst_multi_regs = 0
> + *   mov  %rsi, 8(%rbx,%rcx,4)  # src_reg1 = rsi, src_mem = 0, src_multi_regs = 0
>   *                              # dst_reg1 = rbx, dst_reg2 = rcx, dst_mem = 1
>   *                              # dst_multi_regs = 1, dst_offset = 8
>   */
> --
> 2.43.0
>