linux-kernel - Re: [PATCH] x86/fault: speed up uffd-unit-test by 10x: rate-limit "MCE: Killing" logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf7eaed2-6331-45cc-a66e-76abb5448afe@nvidia.com>
Date: Tue, 7 May 2024 11:10:54 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Axel Rasmussen <axelrasmussen@...gle.com>,
 David Hildenbrand <david@...hat.com>
Cc: Andy Lutomirski <luto@...nel.org>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 x86@...nel.org, "H . Peter Anvin" <hpa@...or.com>,
 LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
 Peter Xu <peterx@...hat.com>
Subject: Re: [PATCH] x86/fault: speed up uffd-unit-test by 10x: rate-limit
 "MCE: Killing" logs

On 5/7/24 11:08 AM, Axel Rasmussen wrote:
> On Tue, May 7, 2024 at 9:43 AM David Hildenbrand <david@...hat.com> wrote:
..
>>> That thread seems to have stalled.
>>
>> Yes, there was no follow-up.
> 
> Apologies, I had completely forgotten about this. I blame the weekend. :)
> 
> No objections from me to the simple rate limiting proposed here, if
> useful you can take:
> 
> Acked-by: Axel Rasmussen <axelrasmussen@...gle.com>
> 
> But, it seems to me the earlier proposal may still be useful.
> Specifically, don't print at all for "synthetic" poisons from
> UFFDIO_POISON or similar mechanisms. This way, "real" errors aren't
> gobbled up by the ratelimit due to spam from "synthetic" errors. If
> folks agree, I can *actually* send a patch this time. :)
> 

That sounds good to me. (Should it also rate limit, though? I'm leaning
toward yes.)

thanks,
-- 
John Hubbard
NVIDIA