linux-kernel - Re: [PATCH 2/4] ASoC: qcom: q6dsp: Implement proper channel mapping in Audioreach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd26593f-31bc-4a1d-abd9-2fbf3539b030@linaro.org>
Date: Tue, 7 May 2024 20:16:09 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 James Schulman <james.schulman@...rus.com>,
 David Rhodes <david.rhodes@...rus.com>,
 Richard Fitzgerald <rf@...nsource.cirrus.com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>, Nuno Sá
 <nuno.sa@...log.com>, Banajit Goswami <bgoswami@...cinc.com>
Cc: alsa-devel@...a-project.org, patches@...nsource.cirrus.com,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] ASoC: qcom: q6dsp: Implement proper channel mapping
 in Audioreach

On 07/05/2024 15:25, Srinivas Kandagatla wrote:
> 
> 
> On 07/05/2024 11:27, Krzysztof Kozlowski wrote:
>> Instead of relying on default channel mapping in all Audioreach
>> platforms, implement set_channel_map() callback to allow sound cards
>> customize the mapping depending on needs.
>>
>> The channel mapping is set on frontend DAIs coming from the topology,
>> not DTS, thus need to add DAI ops in topology dai_load() callback.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>   sound/soc/qcom/qdsp6/audioreach.c |  2 +-
>>   sound/soc/qcom/qdsp6/audioreach.h |  1 +
>>   sound/soc/qcom/qdsp6/q6apm.c      | 28 +++++++++++++++++++++++++++-
>>   sound/soc/qcom/qdsp6/q6apm.h      |  8 ++++++++
>>   sound/soc/qcom/qdsp6/topology.c   | 12 ++++++++++++
>>   5 files changed, 49 insertions(+), 2 deletions(-)
> Please use the existing q6dma_set_channel_map() and set the channel map 
> for the backend dai from machine driver, this should work.
> 
> setting channels on FE is not a scalable one.
> 
> Please take a look at some of the patches that I shared privately.
> 

Ack

Best regards,
Krzysztof