linux-kernel - Re: [RFC PATCH v3 04/17] x86/resctrl: Introduce resctrl_file_fflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f4d2c09-3158-477a-ba9b-f8f809d1999b@intel.com>
Date: Tue, 7 May 2024 13:27:32 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: <babu.moger@....com>, <corbet@....net>, <fenghua.yu@...el.com>,
	<tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
	<dave.hansen@...ux.intel.com>
CC: <x86@...nel.org>, <hpa@...or.com>, <paulmck@...nel.org>,
	<rdunlap@...radead.org>, <tj@...nel.org>, <peterz@...radead.org>,
	<yanjiewtw@...il.com>, <kim.phillips@....com>, <lukas.bulwahn@...il.com>,
	<seanjc@...gle.com>, <jmattson@...gle.com>, <leitao@...ian.org>,
	<jpoimboe@...nel.org>, <rick.p.edgecombe@...el.com>,
	<kirill.shutemov@...ux.intel.com>, <jithu.joseph@...el.com>,
	<kai.huang@...el.com>, <kan.liang@...ux.intel.com>,
	<daniel.sneddon@...ux.intel.com>, <pbonzini@...hat.com>,
	<sandipan.das@....com>, <ilpo.jarvinen@...ux.intel.com>,
	<peternewman@...gle.com>, <maciej.wieczor-retman@...el.com>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<eranian@...gle.com>, <james.morse@....com>
Subject: Re: [RFC PATCH v3 04/17] x86/resctrl: Introduce
 resctrl_file_fflags_init

Hi Babu,

On 5/6/2024 1:23 PM, Moger, Babu wrote:
> On 5/3/24 18:26, Reinette Chatre wrote:
>> Hi Babu,
>>
>> In shortlog, please use () to indicate function:
>> resctrl_file_fflags_init().
>>
>> On 3/28/2024 6:06 PM, Babu Moger wrote:
>>> Consolidate multiple fflags initialization into one function.
>>>
>>> Remove thread_throttle_mode_init, mbm_config_rftype_init and
>>> consolidate them into resctrl_file_fflags_init.
>>
>> This changelog has no context and only describes what the code does,
>> which can be learned from reading the patch. Could you please
>> update changelog with context and motivation for this change?
> How about this?
> 
> Consolidate multiple fflags initialization into one function.
> 
> The functions thread_throttle_mode_init() and mbm_config_rftype_init()
> both initialize fflags for resctrl files. This can be simplified into one
> function passing the file name and flags to be initialized. It also helps
> code simplification of new flags initialized for ABMC feature.

I am not sure what you intend here. Is this the entire intended changelog?
I expected it to reflect x86 requirements as per
Documentation/process/maintainer-tip.rst. Under "Changelog":

"It's also useful to structure the changelog into several paragraphs and not
lump everything together into a single one. A good structure is to explain
the context, the problem and the solution in separate paragraphs and this
order."

Reinette