linux-kernel - Re: [GIT PULL] clk: samsung: drivers for v6.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 07 May 2024 13:43:21 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Michael Turquette <mturquette@...libre.com>
Cc: Chanwoo Choi <cw00.choi@...sung.com>, linux-clk@...r.kernel.org, Sylwester Nawrocki <snawrocki@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>, Peter Griffin <peter.griffin@...aro.org>, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] clk: samsung: drivers for v6.10

Quoting Krzysztof Kozlowski (2024-05-06 22:54:10)
> On 07/05/2024 01:44, Stephen Boyd wrote:
> > Quoting Krzysztof Kozlowski (2024-05-04 05:06:22)
> >> The following changes since commit 4cece764965020c22cff7665b18a012006359095:
> >>
> >>   Linux 6.9-rc1 (2024-03-24 14:10:05 -0700)
> >>
> >> are available in the Git repository at:
> >>
> >>   https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-clk-6.10
> > 
> > I'm getting compile warnings. Is there a pending fix? Also, why is GS101
> 
> I don't see any of these warnings. Neither local (W=1), nor on my CI,
> nor reported by LKP (which reported build successes for this branch).
> How can I reproduce it?

I ran this command

 make W=1 ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- drivers/clk/samsung/clk-gs101.o

and I see the warnings. They're actually upgraded to errors.

> 
> 
> > describing clk parents with strings instead of using clk_parent_data?
> 
> GS101 uses existing Samsuung clock framework, so that's how it is done
> there. There is nothing odd here, comparing to other Samsung clocks.

Ok. Is anyone working on migrating Samsung clk drivers to the non-string
way?

> 
> > 
> > In file included from drivers/clk/samsung/clk-gs101.c:16:
> > drivers/clk/samsung/clk-gs101.c:2616:7: error: ‘mout_hsi2_mmc_card_p’
> > defined but not used [-Werror=unused-const-variable=]
> >  2616 | PNAME(mout_hsi2_mmc_card_p)     = { "fout_shared2_pll", "fout_shared3_pll",
> 
> I see indeed some unused variables and I will drop them but your
> warnings are not reproducible.

Weird! I use gcc-12.2 if that helps. I've been meaning to upgrade but I
also don't see much urgency.

I'll wait for the next PR.