linux-kernel - Re: [PATCH] io_uring/rsrc: Add support for multi-folio buffer coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue,  7 May 2024 13:22:03 +0800
From: Chenliang Li <cliang01.li@...sung.com>
To: axboe@...nel.dk
Cc: asml.silence@...il.com, cliang01.li@...sung.com, gost.dev@...sung.com,
	io-uring@...r.kernel.org, joshi.k@...sung.com, kundan.kumar@...sung.com,
	linux-kernel@...r.kernel.org, peiwei.li@...sung.com
Subject: Re: [PATCH] io_uring/rsrc: Add support for multi-folio buffer
 coalescing

On 5/6/24 6:57 AM, Jens Axboe wrote:
> Can you add some justification to this commit message? A good commit
> message should basically be the WHY of why this commit exists in the
> first place. Your commit message just explains what the patch does,
> which I can just read the code to see for myself.
> 
> As it stands, it's not clear to me or anyone casually reading this
> commit message why the change is being done in the first place.

Thank you for the instruction. I'll submit a V2 patchset with better
commit message.

> Outside of that, you probably want to split this into two parts - one
> that adds the helper for the existing code, then one that modifies it
> for your change. We need this to be as simple as possible to review, as
> we've had a security issue with page coalescing in this code in the
> past.

Will split this in V2.

> Minor comments below, will wait with a full review until this is split
> to be more easily reviewable.

Thank you for the comments. Will address them in V2.