[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <11F5B269-05DD-448E-9F85-878E84A5654F@jrtc27.com>
Date: Tue, 7 May 2024 06:40:52 +0100
From: Jessica Clarke <jrtc27@...c27.com>
To: Charlie Jenkins <charlie@...osinc.com>
Cc: Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Conor Dooley <conor.dooley@...rochip.com>,
Song Liu <song@...nel.org>,
Xi Wang <xi.wang@...il.com>,
Björn Töpel <bjorn@...osinc.com>,
Clément Léger <cleger@...osinc.com>,
linux-riscv <linux-riscv@...ts.infradead.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/8] riscv: Add PLATFORM_MAY_SUPPORT_RISCV_ISA_SVPBMT
Kconfig option
On 7 May 2024, at 02:40, Charlie Jenkins <charlie@...osinc.com> wrote:
>
> Svpbmt would not benefit from having PLATFORM_SUPPORTS_RISCV_ISA_SVPBMT
> so just rename RISCV_ISA_SVPBMT to PLATFORM_MAY_SUPPORT_RISCV_ISA_SVPBMT
> and move the definition to Kconfig.isa.
>
> Signed-off-by: Charlie Jenkins <charlie@...osinc.com>
> ---
> arch/riscv/Kconfig | 17 -----------------
> arch/riscv/Kconfig.isa | 17 +++++++++++++++++
> 2 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 9c3a4347953b..22303a3ab59e 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -484,23 +484,6 @@ config RISCV_ALTERNATIVE_EARLY
> help
> Allows early patching of the kernel for special errata
>
> -config RISCV_ISA_SVPBMT
> - bool "Svpbmt extension support for supervisor mode page-based memory types"
> - depends on 64BIT && MMU
> - depends on RISCV_ALTERNATIVE
> - default y
> - help
> - Add support for the Svpbmt ISA-extension (Supervisor-mode:
> - page-based memory types) in the kernel when it is detected at boot.
> -
> - The memory type for a page contains a combination of attributes
> - that indicate the cacheability, idempotency, and ordering
> - properties for access to that page.
> -
> - The Svpbmt extension is only available on 64-bit cpus.
> -
> - If you don't know what to do here, say Y.
> -
> config TOOLCHAIN_HAS_ZBB
> bool
> default y
> diff --git a/arch/riscv/Kconfig.isa b/arch/riscv/Kconfig.isa
> index 37585bcd763e..50e217dc5719 100644
> --- a/arch/riscv/Kconfig.isa
> +++ b/arch/riscv/Kconfig.isa
> @@ -168,3 +168,20 @@ config PLATFORM_SUPPORTS_RISCV_ISA_SVNAPOT
> not support Svnapot.
>
> endchoice
> +
> +config RISCV_ISA_SVPBMT
Hi Charlie,
Despite the subject and body you haven’t renamed it in this patch?
Jess
> + bool "Svpbmt extension support for supervisor mode page-based memory types"
> + depends on 64BIT && MMU
> + depends on RISCV_ALTERNATIVE
> + default y
> + help
> + Add support for the Svpbmt ISA-extension (Supervisor-mode:
> + page-based memory types) in the kernel when it is detected at boot.
> +
> + The memory type for a page contains a combination of attributes
> + that indicate the cacheability, idempotency, and ordering
> + properties for access to that page.
> +
> + The Svpbmt extension is only available on 64-bit cpus.
> +
> + If you don't know what to do here, say Y.
>
> --
> 2.44.0
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Powered by blists - more mailing lists