linux-kernel - Re: [PATCH] jffs2: nodemgmt: fix kernel-doc comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae3ebe43-be3b-49dd-a5ad-4dae097e9ff8@quicinc.com>
Date: Tue, 7 May 2024 16:11:15 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Randy Dunlap <rdunlap@...radead.org>, <linux-kernel@...r.kernel.org>
CC: David Woodhouse <dwmw2@...radead.org>,
        Richard Weinberger
	<richard@....at>, <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH] jffs2: nodemgmt: fix kernel-doc comments

On 12/5/23 09:32, Randy Dunlap wrote:
> Update the end of one sentence where a comment was truncated. (dwmw2)
> 
> Fix a bunch of kernel-doc warnings:
> 
> nodemgmt.c:72: warning: Function parameter or member 'sumsize' not described in 'jffs2_do_reserve_space'
> nodemgmt.c:72: warning: expecting prototype for jffs2_reserve_space(). Prototype was for jffs2_do_reserve_space() instead
> nodemgmt.c:76: warning: Function parameter or member 'sumsize' not described in 'jffs2_reserve_space'
> nodemgmt.c:76: warning: No description found for return value of 'jffs2_reserve_space'
> nodemgmt.c:503: warning: Function parameter or member 'ofs' not described in 'jffs2_add_physical_node_ref'
> nodemgmt.c:503: warning: Function parameter or member 'ic' not described in 'jffs2_add_physical_node_ref'
> nodemgmt.c:503: warning: Excess function parameter 'new' description in 'jffs2_add_physical_node_ref'
> nodemgmt.c:503: warning: No description found for return value of 'jffs2_add_physical_node_ref'
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: David Woodhouse <dwmw2@...radead.org>
> Cc: Richard Weinberger <richard@....at>
> Cc: linux-mtd@...ts.infradead.org

I was about to submit a patch for these, but then checked lore and saw 
this was posted a while back, but so far not merged. Hopefully my R-B 
will provide some momentum

Reviewed-by: Jeff Johnson <quic_jjohnson@...cinc.com>