linux-kernel - Re: [PATCH] nfc: nci: Fix kcov check in nci_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 7 May 2024 08:22:34 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
 Ryosuke Yasuoka <ryasuoka@...hat.com>, Jeremy Cline <jeremy@...ine.org>,
 "David S. Miller" <davem@...emloft.net>
Cc: syzbot <syzbot+0438378d6f157baae1a2@...kaller.appspotmail.com>,
 edumazet@...gle.com, kuba@...nel.org, linux-kernel@...r.kernel.org,
 linux-wireless@...r.kernel.org, netdev@...r.kernel.org, pabeni@...hat.com,
 syzkaller-bugs@...glegroups.com, Aleksandr Nogikh <nogikh@...gle.com>,
 Andrey Konovalov <andreyknvl@...il.com>,
 Johannes Berg <johannes@...solutions.net>, Dmitry Vyukov <dvyukov@...gle.com>
Subject: Re: [PATCH] nfc: nci: Fix kcov check in nci_rx_work()

On 05/05/2024 12:36, Tetsuo Handa wrote:
> Commit 7e8cdc97148c ("nfc: Add KCOV annotations") added
> kcov_remote_start_common()/kcov_remote_stop() pair into nci_rx_work(),
> with an assumption that kcov_remote_stop() is called upon continue of
> the for loop. But commit d24b03535e5e ("nfc: nci: Fix uninit-value in
> nci_dev_up and nci_ntf_packet") forgot to call kcov_remote_stop() before
> break of the for loop.
> 
> Reported-by: syzbot <syzbot+0438378d6f157baae1a2@...kaller.appspotmail.com>
> Closes: https://syzkaller.appspot.com/bug?extid=0438378d6f157baae1a2
> Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet")
> Debugged-by: Andrey Konovalov <andreyknvl@...il.com>
> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof