linux-kernel - Re: [RFC PATCH 05/11] i2c: core: Avoid config node enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f3cc030-e3cb-4758-8114-7364ce47481a@kernel.org>
Date: Tue, 7 May 2024 08:35:40 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Krishna Yarlagadda <kyarlagadda@...dia.com>, linux-tegra@...r.kernel.org,
 devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-mmc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: thierry.reding@...il.com, jonathanh@...dia.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, corbet@....net,
 andi.shyti@...nel.org, wsa+renesas@...g-engineering.com,
 ulf.hansson@...aro.org, adrian.hunter@...el.com, digetx@...il.com,
 ldewangan@...dia.com, mkumard@...dia.com
Subject: Re: [RFC PATCH 05/11] i2c: core: Avoid config node enumeration

On 07/05/2024 00:51, Krishna Yarlagadda wrote:
> Add "config" as a common node to add device configuration settings and
> other data. This child node should not be treated as a device.
> Skip "config" child node during i2c device registration.
> 
> Signed-off-by: Krishna Yarlagadda <kyarlagadda@...dia.com>
> ---
>  drivers/i2c/i2c-core-of.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c
> index a6c407d36800..f50206c6c4d6 100644
> --- a/drivers/i2c/i2c-core-of.c
> +++ b/drivers/i2c/i2c-core-of.c
> @@ -98,6 +98,9 @@ void of_i2c_register_devices(struct i2c_adapter *adap)
>  		bus = of_node_get(adap->dev.of_node);
>  
>  	for_each_available_child_of_node(bus, node) {
> +		if (!strcmp(node->name, "config"))
> +			continue;

NAK

All children are devices (they have unit addresses). Do not introduce
some another, parallel addressing.

Best regards,
Krzysztof