[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d117754b-fb7c-4889-a49a-76d64f30a372@moroto.mountain>
Date: Tue, 7 May 2024 09:38:25 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Lars Kellogg-Stedman <lars@...bit.com>
Cc: Duoming Zhou <duoming@....edu.cn>, linux-hams@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
pabeni@...hat.com, kuba@...nel.org, edumazet@...gle.com,
davem@...emloft.net, jreuter@...na.de
Subject: Re: [PATCH net] ax25: Fix refcount leak issues of ax25_dev
On Fri, May 03, 2024 at 11:36:37PM +0300, Dan Carpenter wrote:
> Could you test this diff?
>
> regards,
> dan carpenter
>
> diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
> index 558e158c98d0..a7f96a4ceff4 100644
> --- a/net/ax25/af_ax25.c
> +++ b/net/ax25/af_ax25.c
> @@ -1129,8 +1129,10 @@ static int ax25_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)
> /*
> * User already set interface with SO_BINDTODEVICE
> */
> - if (ax25->ax25_dev != NULL)
> + if (ax25->ax25_dev != NULL) {
> + ax25_dev_hold(ax25->ax25_dev);
> goto done;
> + }
>
> if (addr_len > sizeof(struct sockaddr_ax25) && addr->fsa_ax25.sax25_ndigis == 1) {
> if (ax25cmp(&addr->fsa_digipeater[0], &null_ax25_address) != 0 &&
This commit is wrong.
regards,
dan carpenter
Powered by blists - more mailing lists