linux-kernel - Re: [PATCH net-next v6 8/8] ax.25: x.25: Remove the now superfluous sentinel elements from ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240507080219.xp6m5lyx5mt655yg@joelS2.panther.com>
Date: Tue, 7 May 2024 10:02:19 +0200
From: Joel Granados <j.granados@...sung.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Sabrina Dubroca <sd@...asysnail.net>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Alexander Aring
	<alex.aring@...il.com>, Stefan Schmidt <stefan@...enfreihafen.org>, Miquel
	Raynal <miquel.raynal@...tlin.com>, David Ahern <dsahern@...nel.org>,
	Steffen Klassert <steffen.klassert@...unet.com>, Herbert Xu
	<herbert@...dor.apana.org.au>, Matthieu Baerts <matttbe@...nel.org>, Mat
	Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>, Remi
	Denis-Courmont <courmisch@...il.com>, Allison Henderson
	<allison.henderson@...cle.com>, David Howells <dhowells@...hat.com>, Marc
	Dionne <marc.dionne@...istor.com>, Marcelo Ricardo Leitner
	<marcelo.leitner@...il.com>, Xin Long <lucien.xin@...il.com>, Wenjia Zhang
	<wenjia@...ux.ibm.com>, Jan Karcher <jaka@...ux.ibm.com>, "D. Wythe"
	<alibuda@...ux.alibaba.com>, Tony Lu <tonylu@...ux.alibaba.com>, Wen Gu
	<guwen@...ux.alibaba.com>, Trond Myklebust
	<trond.myklebust@...merspace.com>, Anna Schumaker <anna@...nel.org>, Chuck
	Lever <chuck.lever@...cle.com>, Jeff Layton <jlayton@...nel.org>, Neil Brown
	<neilb@...e.de>, Olga Kornievskaia <kolga@...app.com>, Dai Ngo
	<Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>, Jon Maloy
	<jmaloy@...hat.com>, Ying Xue <ying.xue@...driver.com>, Martin Schiller
	<ms@....tdt.de>, Pablo Neira Ayuso <pablo@...filter.org>, Jozsef Kadlecsik
	<kadlec@...filter.org>, Florian Westphal <fw@...len.de>, Roopa Prabhu
	<roopa@...dia.com>, Nikolay Aleksandrov <razor@...ckwall.org>, Simon Horman
	<horms@...ge.net.au>, Julian Anastasov <ja@....bg>, Joerg Reuter
	<jreuter@...na.de>, Luis Chamberlain <mcgrof@...nel.org>, Kees Cook
	<keescook@...omium.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <dccp@...r.kernel.org>,
	<linux-wpan@...r.kernel.org>, <mptcp@...ts.linux.dev>,
	<linux-hams@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
	<rds-devel@....oracle.com>, <linux-afs@...ts.infradead.org>,
	<linux-sctp@...r.kernel.org>, <linux-s390@...r.kernel.org>,
	<linux-nfs@...r.kernel.org>, <tipc-discussion@...ts.sourceforge.net>,
	<linux-x25@...r.kernel.org>, <netfilter-devel@...r.kernel.org>,
	<coreteam@...filter.org>, <bridge@...ts.linux.dev>,
	<lvs-devel@...r.kernel.org>
Subject: Re: [PATCH net-next v6 8/8] ax.25: x.25: Remove the now superfluous
 sentinel elements from ctl_table array

On Fri, May 03, 2024 at 06:23:14PM +0300, Dan Carpenter wrote:
> On Fri, May 03, 2024 at 02:18:11PM +0200, Joel Granados wrote:
> > On Wed, May 01, 2024 at 03:15:54PM +0200, Sabrina Dubroca wrote:
> > > 2024-05-01, 11:29:32 +0200, Joel Granados via B4 Relay wrote:
> > > > From: Joel Granados <j.granados@...sung.com>
> > > > diff --git a/net/ax25/ax25_ds_timer.c b/net/ax25/ax25_ds_timer.c
> > > > index c4f8adbf8144..c50a58d9e368 100644
> > > > --- a/net/ax25/ax25_ds_timer.c
> > > > +++ b/net/ax25/ax25_ds_timer.c
> > > > @@ -55,6 +55,7 @@ void ax25_ds_set_timer(ax25_dev *ax25_dev)
> > > >  	ax25_dev->dama.slave_timeout =
> > > >  		msecs_to_jiffies(ax25_dev->values[AX25_VALUES_DS_TIMEOUT]) / 10;
> > > >  	mod_timer(&ax25_dev->dama.slave_timer, jiffies + HZ);
> > > > +	return;
> > > 
> > > nit: return not needed here since we're already at the bottom of the
> > > function, but probably not worth a repost of the series.
> > > 
> > Thx. I will not repost, but I have changed them locally so they are
> > there in case a V7 is required.
> > 
> 
> It's a checkpatch.pl -f warning so we probably will want to fix it
> eventually.

According to [1] the patchset has already been applied. So I'll just
send another patch for it to be applied on top.

Thx for pointing this out.


[1] https://patchwork.kernel.org/project/netdevbpf/patch/20240501-jag-sysctl_remset_net-v6-1-370b702b6b4a@samsung.com/
-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)