linux-kernel - [PATCH net-next] ax25: Remove superfuous "return" from ax25_ds_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240507-jag-fix_void_ret_ax25-v1-1-507fb246f192@samsung.com>
Date: Tue, 07 May 2024 10:40:39 +0200
From: Joel Granados via B4 Relay <devnull+j.granados.samsung.com@...nel.org>
To: Joerg Reuter <jreuter@...na.de>, 
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: linux-hams@...r.kernel.org, netdev@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Joel Granados <j.granados@...sung.com>
Subject: [PATCH net-next] ax25: Remove superfuous "return" from
 ax25_ds_set_timer

From: Joel Granados <j.granados@...sung.com>

Remove the explicit call to "return" in the void ax25_ds_set_timer
function that was introduced in 78a7b5dbc060 ("ax.25: x.25: Remove the
now superfluous sentinel elements from ctl_table array").

Signed-off-by: Joel Granados <j.granados@...sung.com>
---
I did not include a "Fixes:" tag as this (IMO) should not be backported
into a stable kernel. I'm assuming that net-next is going to be merged
into mainline as is and therefore I linked to a specific commit ID (get
back to me if I should do something different)

This comes after a review from Dave Carpenter [1] to an already accepted
patchset [2]

[1] https://lore.kernel.org/all/20240501-jag-sysctl_remset_net-v6-8-370b702b6b4a@samsung.com
[2] https://patchwork.kernel.org/project/netdevbpf/patch/20240501-jag-sysctl_remset_net-v6-1-370b702b6b4a@samsung.com/ 
---
 net/ax25/ax25_ds_timer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ax25/ax25_ds_timer.c b/net/ax25/ax25_ds_timer.c
index c50a58d9e368..c4f8adbf8144 100644
--- a/net/ax25/ax25_ds_timer.c
+++ b/net/ax25/ax25_ds_timer.c
@@ -55,7 +55,6 @@ void ax25_ds_set_timer(ax25_dev *ax25_dev)
 	ax25_dev->dama.slave_timeout =
 		msecs_to_jiffies(ax25_dev->values[AX25_VALUES_DS_TIMEOUT]) / 10;
 	mod_timer(&ax25_dev->dama.slave_timer, jiffies + HZ);
-	return;
 }

 /*

---
base-commit: 179a6f5df8dab7d027aa73a302d8506c6533e463
change-id: 20240507-jag-fix_void_ret_ax25-c78105dcdf79

Best regards,
-- 
Joel Granados <j.granados@...sung.com>