linux-kernel - Re: [PATCH v2 2/4] kbuild: do not add $(srctree) or $(objtree) to header search paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjnsKnjNhXwh5uz1@buildd.core.avm.de>
Date: Tue, 7 May 2024 10:54:02 +0200
From: Nicolas Schier <n.schier@....de>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2 2/4] kbuild: do not add $(srctree) or $(objtree) to
 header search paths

On Sat, Apr 27, 2024 at 11:55:00PM +0900, Masahiro Yamada wrote:
> scripts/Makefile.lib is included not only from scripts/Makefile.build
> but also from scripts/Makefile.{vmlinux,modfinal} for building generated
> C files.
> 
> In scripts/Makefile.{vmlinux,modfinal}, $(obj) and $(src) are empty.
> 
> Therefore, the header include paths:
> 
>     -I $(srctree)/$(src) -I $(objtree)/$(obj)
> 
> ... become meaningless code:
> 
>     -I $(srctree)/ -I $(objtree)/
> 
> Add these paths only when 'obj' and 'src' are defined.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202404170634.BlqTaYA0-lkp@intel.com/
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
> Changes in v2:
>  - New patch to address the build error reported by 0day bot

Reviewed-by: Nicolas Schier <n.schier@....de>