linux-kernel - Re: [PATCH net-next v9] net/ipv4: add tracepoint for icmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240507050917.238a0891@rorschach.local.home>
Date: Tue, 7 May 2024 05:09:17 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: <xu.xin16@....com.cn>
Cc: <kuba@...nel.org>, <horms@...nel.org>, <davem@...emloft.net>,
 <mhiramat@...nel.org>, <dsahern@...nel.org>,
 <linux-kernel@...r.kernel.org>, <linux-trace-kernel@...r.kernel.org>,
 <netdev@...r.kernel.org>, <yang.yang29@....com.cn>, <he.peilin@....com.cn>,
 <liu.chun2@....com.cn>, <jiang.xuexin@....com.cn>,
 <zhang.yunkai@....com.cn>, <kerneljasonxing@...il.com>,
 <fan.yu9@....com.cn>, <qiu.yutan@....com.cn>, <ran.xiaokai@....com.cn>,
 <zhang.run@....com.cn>, <wang.haoyi@....com.cn>, <si.hao@....com.cn>,
 <lu.zhongjun@....com.cn>
Subject: Re: [PATCH net-next v9] net/ipv4: add tracepoint for icmp_send

On Tue, 7 May 2024 15:41:03 +0800 (CST)
<xu.xin16@....com.cn> wrote:

> From: Peilin He <he.peilin@....com.cn>
> 
> Introduce a tracepoint for icmp_send, which can help users to get more
> detail information conveniently when icmp abnormal events happen.
> 
> 1. Giving an usecase example:
> =============================
> When an application experiences packet loss due to an unreachable UDP
> destination port, the kernel will send an exception message through the
> icmp_send function. By adding a trace point for icmp_send, developers or
> system administrators can obtain detailed information about the UDP
> packet loss, including the type, code, source address, destination address,
> source port, and destination port. This facilitates the trouble-shooting
> of UDP packet loss issues especially for those network-service
> applications.
> 
> 2. Operation Instructions:
> ==========================
> Switch to the tracing directory.
>         cd /sys/kernel/tracing
> Filter for destination port unreachable.
>         echo "type==3 && code==3" > events/icmp/icmp_send/filter
> Enable trace event.
>         echo 1 > events/icmp/icmp_send/enable
> 
> 3. Result View:
> ================
>  udp_client_erro-11370   [002] ...s.12   124.728002:
>  icmp_send: icmp_send: type=3, code=3.
>  From 127.0.0.1:41895 to 127.0.0.1:6666 ulen=23
>  skbaddr=00000000589b167a
> 
> Signed-off-by: Peilin He <he.peilin@....com.cn>
> Signed-off-by: xu xin <xu.xin16@....com.cn>
> Reviewed-by: Yunkai Zhang <zhang.yunkai@....com.cn>
> Cc: Yang Yang <yang.yang29@....com.cn>
> Cc: Liu Chun <liu.chun2@....com.cn>
> Cc: Xuexin Jiang <jiang.xuexin@....com.cn>
> ---

From just a tracing point of view:

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve