linux-kernel - [PATCH v2] perf daemon: Fix the warning about time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240507090241.3853998-1-ben717@andestech.com>
Date: Tue, 7 May 2024 17:02:41 +0800
From: Ben Zong-You Xie <ben717@...estech.com>
To: <linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <acme@...nel.org>, <namhyung@...nel.org>, <mark.rutland@....com>,
        <alexander.shishkin@...ux.intel.com>, <jolsa@...nel.org>,
        <irogers@...gle.com>, <adrian.hunter@...el.com>,
        Ben Zong-You Xie
	<ben717@...estech.com>
Subject: [PATCH v2] perf daemon: Fix the warning about time_t

On the 32-bit platform, the size of time_t is 32 bits or 64 bits according
to the architecture. Therefore, use typecasting to resolve the warnings
for some architectures, e.g. RISC-V.

Signed-off-by: Ben Zong-You Xie <ben717@...estech.com>
---

v2: By Palmer's remind, patch v1 may introduce a warning for some
    other targets. Thus, use typecasting instead.
 
---
 tools/perf/builtin-daemon.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c
index 83954af36753..cb04caa902e8 100644
--- a/tools/perf/builtin-daemon.c
+++ b/tools/perf/builtin-daemon.c
@@ -688,9 +688,10 @@ static int cmd_session_list(struct daemon *daemon, union cmd *cmd, FILE *out)
 			/* lock */
 			csv_sep, daemon->base, "lock");
 
-		fprintf(out, "%c%lu",
+		fprintf(out, "%c%llu",
 			/* session up time */
-			csv_sep, (curr - daemon->start) / 60);
+			csv_sep,
+			(unsigned long long)((curr - daemon->start) / 60));
 
 		fprintf(out, "\n");
 	} else {
@@ -700,8 +701,8 @@ static int cmd_session_list(struct daemon *daemon, union cmd *cmd, FILE *out)
 				daemon->base, SESSION_OUTPUT);
 			fprintf(out, "  lock:    %s/lock\n",
 				daemon->base);
-			fprintf(out, "  up:      %lu minutes\n",
-				(curr - daemon->start) / 60);
+			fprintf(out, "  up:      %llu minutes\n",
+				(unsigned long long)((curr - daemon->start) / 60));
 		}
 	}
 
@@ -727,9 +728,10 @@ static int cmd_session_list(struct daemon *daemon, union cmd *cmd, FILE *out)
 				/* session ack */
 				csv_sep, session->base, SESSION_ACK);
 
-			fprintf(out, "%c%lu",
+			fprintf(out, "%c%llu",
 				/* session up time */
-				csv_sep, (curr - session->start) / 60);
+				csv_sep,
+				(unsigned long long)((curr - session->start) / 60));
 
 			fprintf(out, "\n");
 		} else {
@@ -745,8 +747,8 @@ static int cmd_session_list(struct daemon *daemon, union cmd *cmd, FILE *out)
 				session->base, SESSION_CONTROL);
 			fprintf(out, "  ack:     %s/%s\n",
 				session->base, SESSION_ACK);
-			fprintf(out, "  up:      %lu minutes\n",
-				(curr - session->start) / 60);
+			fprintf(out, "  up:      %llu minutes\n",
+				(unsigned long long)((curr - session->start) / 60));
 		}
 	}
 
-- 
2.34.1