linux-kernel - Re: [PATCH v2 0/4] acpi/ghes, cper, cxl: Trace FW-First CXL Protocol Errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2649256.vYhyI6sBWr@fdefranc-mobl3>
Date: Tue, 07 May 2024 11:35:09 +0200
From: "Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>
To: Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>
Cc: linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-cxl@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
 Alison Schofield <alison.schofield@...el.com>,
 Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
 Dan Williams <dan.j.williams@...el.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Yazen Ghannam <yazen.ghannam@....com>,
 Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>
Subject: Re: [PATCH v2 0/4] acpi/ghes, cper,
 cxl: Trace FW-First CXL Protocol Errors

On Tuesday, January 9, 2024 4:47:51 AM GMT+2 Smita Koralahalli wrote:
> This patchset adds trace event support for FW-First Protocol Errors.
> 
> This series depends on:
> https://lore.kernel.org/linux-cxl/20231220-cxl-cper-v5-0-1bb8a4ca2c7a@intel.
> com
> 
Hello Smita,

I'm working on a small series of enhancement and additions to kernel logs and 
trace events in extlog_print() (ELOG). I'm interested to reuse from ELOG the 
infrastructure which you made to trace the CXL Protocol Errors.

I'm aware that this series depends on an old one from Ira which has been 
superseded by a different implementation and, furthermore, that this needs to 
be reworked   because the execution of this code may sleep while in atomic 
context. 

I'd like to ask if you plan to fix and rebase this series to a current cxl 
branch. If so, I'll wait for the next version to integrate in ELOG.

Otherwise, if you are not anymore actively working on this series, please 
notice that I'd be glad to help by making the necessary changes and by porting 
your code to a current cxl branch (of course, retaining your authorship).

Thanks,

Fabio M. De Francesco
>
> Link to v1:
> https://lore.kernel.org/all/20240102150933.161009-1-Smita.KoralahalliChannab
> asappa@....com
> 
> Smita Koralahalli (4):
>   acpi/ghes, cxl: Create a common CXL struct to handle different CXL
>     CPER records
>   efi/cper, cxl: Make definitions and structures global
>   acpi/ghes, efi/cper: Recognize and process CXL Protocol Errors.
>   acpi/ghes, cxl/pci: Trace FW-First CXL Protocol Errors
> 
>  drivers/acpi/apei/ghes.c        | 22 ++++++++-
>  drivers/cxl/core/pci.c          | 29 ++++++++++++
>  drivers/cxl/cxlpci.h            |  3 ++
>  drivers/cxl/pci.c               | 13 ++++--
>  drivers/firmware/efi/cper_cxl.c | 79 ++++++++++++++++++++++++++++-----
>  drivers/firmware/efi/cper_cxl.h |  7 +--
>  include/linux/cper.h            |  4 ++
>  include/linux/cxl-event.h       | 31 ++++++++++++-
>  8 files changed, 166 insertions(+), 22 deletions(-)