linux-kernel - Re: [PATCH net-next 1/2] IB/hfi1: Do not use custom stat allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 7 May 2024 03:07:05 -0700
From: Breno Leitao <leitao@...ian.org>
To: Leon Romanovsky <leon@...nel.org>
Cc: Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
	Jason Gunthorpe <jgg@...pe.ca>, netdev@...r.kernel.org,
	"open list:HFI1 DRIVER" <linux-rdma@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] IB/hfi1: Do not use custom stat allocator

Hello Leon,

On Sun, May 05, 2024 at 05:10:32PM +0300, Leon Romanovsky wrote:
> On Fri, May 03, 2024 at 04:13:31AM -0700, Breno Leitao wrote:
> > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> > convert veth & vrf"), stats allocation could be done on net core
> > instead of in this driver.
> > 
> > With this new approach, the driver doesn't have to bother with error
> > handling (allocation failure checking, making sure free happens in the
> > right spot, etc). This is core responsibility now.
> > 
> > Remove the allocation in the hfi1 driver and leverage the network
> > core allocation instead.
> > 
> > Signed-off-by: Breno Leitao <leitao@...ian.org>
> > ---
> >  drivers/infiniband/hw/hfi1/ipoib_main.c | 19 +++----------------
> >  1 file changed, 3 insertions(+), 16 deletions(-)
> 
> Please use rdma-next in the PATCH subject line, when sending patches for RDMA.

Thanks for the heads-up. I will make sure I use rdma-next in the next RDMA patches.