linux-kernel - Re: [PATCH v3 7/8] PCI: Make minimum bridge window alignment reference more obvious

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 7 May 2024 13:50:36 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Mika Westerberg <mika.westerberg@...ux.intel.com>
cc: linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, 
    Lorenzo Pieralisi <lorenzo.pieralisi@....com>, 
    Rob Herring <robh@...nel.org>, 
    Krzysztof Wilczyński <kw@...ux.com>, 
    Igor Mammedov <imammedo@...hat.com>, 
    Andy Shevchenko <andriy.shevchenko@...el.com>, 
    "Rafael J . Wysocki" <rafael@...nel.org>, 
    Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 7/8] PCI: Make minimum bridge window alignment reference
 more obvious

On Tue, 7 May 2024, Mika Westerberg wrote:

> On Tue, May 07, 2024 at 01:25:22PM +0300, Ilpo Järvinen wrote:
> > Calculations related to bridge window size contain literal 20 that is
> > the minimum alignment for a bridge window. Make the code more obvious
> > by converting the literal 20 to __ffs(SZ_1MB).
> 
> I think that's SZ_1M not SZ_1MB :)

Of course, that's the only place which is not checked by the compiler so 
it's the place where I type it wrong and forget to use backspace. :-)

> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> 
> Looks good, may be even add a #define for this but either way,

I considered that but I could not find a good name for the whole construct 
(with the __ffs() I mean). Perhaps PCI_BRIDGE_WINDOW_LSB could be an 
option but that feels somewhat clumsy to me.

-- 
 i.